On Mon, Oct 24, 2016 at 02:49:38PM +0200, Christoph Hellwig wrote: > But this has a profound effect on the NVMe operation, because fo > example the NVMe reset cycle is tied into PCIe function states. > > Please bring this issue up with the relevant standards comittee first, > otherwise we're getting us into a nightmare of undefined behavior here. > > And it's not like Intel isn't active in this group. I'd suggest you > talk to Amber who is the editor for both the AHCI and NVMe spec, > that should get you started. Amber is aware of this and was supportive in having Intel open the specs to enable this hardware. The nvme driver has weird hooks to support the non-standard open channel effort, and we let Apple dictate this driver can't have q-word access. This remapping isn't exactly the first time we're helping non-standard devices, and Dan's series looks isolated such that it won't harm compliant ones. Dan, I take it you have access to this platform. Would you be able verify if it can successfully resume from S3 and S4? -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html