I prefer having the feature conditional so you can use the CFQ scheduler with I/O priorities as is. If you decide to enable the feature then the priorities will be passed down to the drive in addition to the work that the CFQ scheduler does. Since this feature may change the user perceived performance of the device I want to make sure they know what they are getting into.
On 9/27/16, 7:06 PM, "Christoph Hellwig" <hch@xxxxxxxxxxxxx> wrote:
>The series looks fine to me:
>
>Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
>The only question is if we need to bother with the last patch to
>make the feature conditional at all, given that we both need hardware
>support and applications opting into using I/O priorities to even use
>it. But if you feel it's safer that way the unable certainly doesn't
>hurt.
��.n��������+%������w��{.n�����{��'^�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
