On Thu, 2016-07-14 at 13:48 +0300, Dan Carpenter wrote: > There was clearly supposed to be a break statement here. Currently we > use the k2 ata timings instead of sh ata ones we intended. Probably no > one has this hardware anymore so it likely doesn't make a difference > beyond the static checker warning. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> Should probably also: CC: stable@xxxxxxxxxxxxxxx > diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c > index 7f0434f..0c5d3a9 100644 > --- a/drivers/ide/pmac.c > +++ b/drivers/ide/pmac.c > @@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32 *timings, u32 *timings2, > *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr; > *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN; > } > + break; > case controller_un_ata6: > case controller_k2_ata6: { > /* 100Mhz cell */ -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html