On Wed, Jul 13, 2016 at 04:37:31PM +0200, Arnd Bergmann wrote: > On Wednesday, July 13, 2016 12:59:23 PM CEST Bartlomiej Zolnierkiewicz wrote: > > > > On Friday, July 08, 2016 10:23:48 PM Arnd Bergmann wrote: > > > On Friday, July 8, 2016 5:24:41 PM CEST Bartlomiej Zolnierkiewicz wrote: > > > > This patch disables deprecated IDE subsystem in assabet_defconfig > > > > (no IDE host drivers are selected in this config so there is no > > > > valid reason to enable IDE subsystem itself). > > > > > > > > Cc: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx> > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > > > > > > I think the series makes a lot of sense. I have checked your assertions > > > in the changelogs and found no flaws in your logic, so I think we should > > > take them all through arm-soc unless there are other concerns. > > > > Thank you. > > > > Should I resend everything or just patches that were not reposted yet > > (the ones that were marked as RFT initially and got no feedback)? > > I'd be fine with just getting a pull request with all the patches that > had no negative feedback and that were not already applied (if any). I'd actually say be very careful about this - there's a big difference between the ATA subsystem and IDE subsystem. I've had situations with old platforms where stuff works with IDE and not ATA. For example, using the CY82C693 driver used to work with the IDE subsystem before it got broken on ARM systems with DMA disabled (because the CY82C693 deadlocks the PCI bus on any BM-DMA). From what I remember, ATA provided no easy way to disable DMA on such interfaces. I also looked at using ATA on EBSA110, and it was far from trivial due to munged address lines and access size problems: with IDE, it was easy to work around by redirecting the in*/out* appropriately on a per-driver basis. I forget exactly why ATA didn't work, but it didn't and I came to the conclusion that it was not feasible to fix. So, please don't assume that ATA can be simply slotted in instead of IDE. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
