Yeah it said "One identification descriptor..." but not "Only one identification descriptor...". So I suppose it is *alright* to also return t10 designator in addition to the WWN. It's just redundunt and unnecessary (and that's why I sent the patch), since we only need one LU name (either derive from the WWN, or the t10 identification when WWN is not available): If the ATA IDENTIFY DEVICE data word 87 bit 8 is set to one indicating that the ATA device supports the WORLD WIDE NAME field (i.e., ATA IDENTIFY DEVICE data words 108 to 111), then the SATL shall include a designation descriptor containing a logical unit name as defined in 10.5.4.2.2. If the ATA IDENTIFY DEVICE data word 87 bit 8 is set to zero, indicating that the ATA device does not support the WORLD WIDE NAME field (i.e., ATA IDENTIFY DEVICE data words 108 to 111), then the SATL shall include an identification descriptor containing a logical unit name as defined in 10.5.4.2.3. (sat4r05f.pdf) On 7 July 2016 at 20:44, Hannes Reinecke <hare@xxxxxxx> wrote: > On 07/07/2016 02:40 PM, Tom Yan wrote: >> Well, udev uses its own `ata_id` (which issues IDENTIFY DEVICE through >> ATA PASS-THROUGH) though. >> >> Anyway I expected the reasoning you gave and I can't really argue with >> you. It's just personally I still prefer a cleaner SATL implementation >> (considering Linux is open source and can be deemed as some sort of >> reference), so I gave it a go. >> >> Not that SAT requires the DI VPD return only one desingator / LU name though. >> > Really? > > sat-r08 has: > > One identification descriptor for a logical unit (i.e., a logical unit > name) shall be included (see clause 10.3.4.2). > In some environments, one or more additional identification descriptors > may be included (see clause 10.3.4.3). > > Am I misreading something? > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke Teamlead Storage & Networking > hare@xxxxxxx +49 911 74053 688 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton > HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
