Hello, On Tue, Jun 21, 2016 at 07:49:26AM +0200, Hannes Reinecke wrote: > Yes. Most of the SATA drivers (with the exception of ahci) don't know > about NCQ NON DATA commands, so they use the test for 'NCQ' as a > shorthand for 'NCQ command with DMA data'. > With the introduction of the ATA_PROT_NODATA protocol variable these two > are no longer equivalent, as you can have NCQ commands without DMA. > As I haven't vetted any of those adapters for NCQ NON DATA commands, and > these driver internally also assume that any NCQ command will have > DMA-able data, I thought it prudent to introduce an ata_is_fpdma() flag, > which retains the original meaning of ata_is_ncq(). In that case, the patch description needs to be way beefier. As it is, it looks like a trivial cleanup patch which it isn't. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
