On 04/04/2016 01:13 PM, Sergei Shtylyov wrote: > Hello. > > On 4/4/2016 12:47 PM, Hannes Reinecke wrote: > >> Device-managed ZAC devices just set the zoned capabilities field >> in INQUIRY byte 69 (cf ACS-4). This corresponds to the 'zoned' >> field in the block device characteristics VPD page. >> As this is only defined in SPC-5/SBC-4 we also need to update >> the supported SCSI version descriptor. >> >> Signed-off-by: Hannes Reinecke <hare@xxxxxxx> >> --- >> drivers/ata/libata-scsi.c | 19 ++++++++++--------- >> include/linux/ata.h | 5 +++++ >> 2 files changed, 15 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c >> index 6db2aaf..ff95ef6 100644 >> --- a/drivers/ata/libata-scsi.c >> +++ b/drivers/ata/libata-scsi.c > [...] >> @@ -2316,12 +2314,15 @@ static unsigned int >> ata_scsiop_inq_b1(struct ata_scsi_args *args, u8 *rbuf) >> { >> int form_factor = ata_id_form_factor(args->id); >> int media_rotation_rate = ata_id_rotation_rate(args->id); >> + u8 zoned = ata_id_zoned_cap(args->id); >> >> rbuf[1] = 0xb1; >> rbuf[3] = 0x3c; >> rbuf[4] = media_rotation_rate >> 8; >> rbuf[5] = media_rotation_rate; >> rbuf[7] = form_factor; >> + if (zoned) >> + rbuf[8] = (zoned << 4); > > Parens not needed here. > > [...] > > MBR, Sergei > Thanks, will be fixing it up with the next round of submissions. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html