Re: [PATCH] libata-core: Allow longer timeout for drive spinup from PUIS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tejun,

>On Tue, Mar 22, 2016 at 08:22:22AM +0000, Damien Le Moal wrote:
>> diff --git a/include/linux/ata.h b/include/linux/ata.h
>> index c1a2f34..f460e7f 100644
>> --- a/include/linux/ata.h
>> +++ b/include/linux/ata.h
>> @@ -371,7 +371,8 @@ enum {
>>  	SETFEATURES_AAM_ON	= 0x42,
>>  	SETFEATURES_AAM_OFF	= 0xC2,
>>  
>> -	SETFEATURES_SPINUP	= 0x07, /* Spin-up drive */
>> +	SETFEATURES_SPINUP		= 0x07, /* Spin-up drive */
>> +	SETFEATURES_SPINUP_TIMEOUT	= 30, /* 30s timeout for drive spin-up from PUIS */
>
>Other timeout constants are defined in msecs.  Let's do the same here.
>Also, can you please send the email as plain-text without the base64
>encoding?  If you can't, please send the patch as an attachment
>instead.

Sorry about the email format (I am sending emails in plain text, but my
Outlook exchange client/exchange server does not seem to be respecting
that format).

Here is the patch as attachment, reworked to define the timeout in
milliseconds as you suggested.

Thank you.

Best regards.


--
Damien Le Moal, Ph.D.
Sr Manager, System Software Group, WW Research,
HGST, a Western Digital company
Damien.LeMoal@xxxxxxxx
Tel: (+81) 0466-98-3593 (Ext. 51-3593)
1 kirihara-cho, Fujisawa, Kanagawa, 252-0888 Japan
www.hgst.com <http://www.hgst.com>
Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:

This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.

Attachment: set-features-spinup-timeout.patch
Description: set-features-spinup-timeout.patch


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux