Re: failures due to "libata: disable forced PORTS_IMPL for >= AHCI 1.3 patch"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 23/03/16 18:28, Justin Maggard wrote:
On Wed, Mar 23, 2016 at 9:36 AM, Srinivas Kandagatla
<srinivas.kandagatla@xxxxxxxxxx> wrote:
Hi Tejun,

Its bit late but just found that commit 566d18 "libata: disable forced
PORTS_IMPL for >= AHCI 1.3" is breaking AHCI on Qualcomm APQ8064 platforms
in the mainline kernel (arch/arm/boot/dts/qcom-apq8064.dtsi).

This platform uses "generic-ahci" platform driver and reports AHCI version
as 0x10300, and PORTS_IMPL is never set, so the existing workaround was
correct for this platform, however the latest patch broken this.

There are few ways to fix this issue,

1> Add new compatible string to achi_platform driver so that this platform
can force the port_map,

Or

2> Have a generic dt binding to force the port map.


A generic dt binding is probably a better way forward.  The Annapurna
Alpine platform seems to have the same issue.

+1 for generic bindings.

I suspected that other platforms would also hit the same issue.

--srini

-Justin

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux