Re: [PATCH] pata-rb532-cf: get rid of the irq_to_gpio() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 17 February 2016 12:58:20 Gabor Juhos wrote:
> The RB532 platform specific irq_to_gpio() implementation has been
> removed with commit 832f5dacfa0b ("MIPS: Remove all the uses of
> custom gpio.h"). Now the platform uses the generic stub which causes
> the following error:
> 
>   pata-rb532-cf pata-rb532-cf: no GPIO found for irq149
>   pata-rb532-cf: probe of pata-rb532-cf failed with error -2
> 
> Drop the irq_to_gpio() call and get the GPIO number from platform
> data instead. After this change, the driver works again:
> 
>   scsi host0: pata-rb532-cf
>   ata1: PATA max PIO4 irq 149
>   ata1.00: CFA: CF 1GB, 20080820, max MWDMA4
>   ata1.00: 1989792 sectors, multi 0: LBA
>   ata1.00: configured for PIO4
>   scsi 0:0:0:0: Direct-Access     ATA      CF 1GB           0820 PQ: 0\
>   ANSI: 5
>   sd 0:0:0:0: [sda] 1989792 512-byte logical blocks: (1.01 GB/971 MiB)
>   sd 0:0:0:0: [sda] Write Protect is off
>   sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't\
>   support DPO or FUA
>    sda: sda1 sda2
>   sd 0:0:0:0: [sda] Attached SCSI disk
> 
> Fixes: 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h")
> Cc: Alban Bedel <albeu@xxxxxxx>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Gabor Juhos <juhosg@xxxxxxxxxxx>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

The patch looks good, but I now saw that drivers/pcmcia/db1xxx_ss.c
must have been broken by the same patch as this one, and it probably
needs a similar fix.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux