Re: [PATCH V2] AHCI: Workaround for ThunderX Errata#22536

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 02/14/2016 09:01 AM, Tejun Heo wrote:
Hello,

On Fri, Feb 12, 2016 at 03:20:30PM -0800, tchalamarla@xxxxxxxxxxxxxxxxxx wrote:
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 546a369..76e310e 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1560,6 +1560,9 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
  	if (ahci_broken_devslp(pdev))
  		hpriv->flags |= AHCI_HFLAG_NO_DEVSLP;

+	if (pdev->vendor == 0x177d && pdev->device == 0xa01c)
+		ahci_thunderx_init(&pdev->dev, hpriv);

So, this would make ahci fail to build if thunderx is not configured.
Maybe we should add an additional callback to update hpriv.

  	/* save initial config */
  	ahci_pci_save_initial_config(pdev, hpriv);

diff --git a/drivers/ata/ahci_thunderx.c b/drivers/ata/ahci_thunderx.c

This driver isn't upstream yet, right?  Maybe just fold this change
together?

There is no need for special Driver, AHCI is sufficient for ThunderX, the file only contains this interrupt handler, is it preferable if this interrupt handler in libahci.c with others, instead of separate file?

Thanks,
Tirumalesh.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux