On Tuesday 27 October 2015 15:48:07 Jaedon Shin wrote:
>
> static const struct of_device_id brcm_sata_phy_of_match[] = {
> - { .compatible = "brcm,bcm7445-sata-phy" },
> + { .compatible = "brcm,bcm7445-sata-phy",
> + .data = (void *)BRCM_SATA_PHY_28NM },
> {},
> };
> MODULE_DEVICE_TABLE(of, brcm_sata_phy_of_match);
> @@ -135,6 +145,7 @@ static int brcm_sata_phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct device_node *dn = dev->of_node, *child;
> + const struct of_device_id *of_id;
> struct brcm_sata_phy *priv;
> struct resource *res;
> struct phy_provider *provider;
> @@ -154,6 +165,12 @@ static int brcm_sata_phy_probe(struct platform_device *pdev)
> if (IS_ERR(priv->phy_base))
> return PTR_ERR(priv->phy_base);
>
> + of_id = of_match_node(brcm_sata_phy_of_match, dn);
> + if (of_id)
> + priv->version = (enum brcm_sata_phy_version)of_id->data;
> + else
> + priv->version = BRCM_SATA_PHY_28NM;
> +
>
As you don't actually use that variable except to set the 'offset' for
phy_base, it would be nicer to use a structure that you can point to:
struct brcm_sata_phy_data {
unsigned long offset;
};
const struct brcm_sata_phy_data brcm_sata_phy_28nm = {
.offset = SATA_MDIO_REG_28NM_SPACE_SIZE,
};
static const struct of_device_id brcm_sata_phy_of_match[] = {
{ .compatible = "brcm,bcm7445-sata-phy", .data = &brcm_sata_phy_28nm },
{},
};
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
