>From 8c0fa3e7ca99b0d6d96cb2cf194a912f643da7c5 Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@xxxxxxxxxx>
Date: Mon, 3 Aug 2015 11:10:45 -0400
fe7173c206de ("libata: Implement support for sense data reporting")
and subsequent patches enabled NCQ autosense reporting; unfortunately,
this breaks libata EH behavior for devices which support the feature
because it assumes that only ATAPI devices report sense data and that
sense data trumps explicit device error indication.
For now, disable NCQ autosense.
Cc: stable@xxxxxxxxxxxxxxx # v4.1+
Fixes: fe7173c206de ("libata: Implement support for sense data reporting")
---
drivers/ata/libata-core.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index db5d9f7..32451ac 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2151,6 +2151,13 @@ static void ata_dev_config_sense_reporting(struct ata_device *dev)
{
unsigned int err_mask;
+ /*
+ * FIXME: This makes ATA devices report sense data on failure which
+ * in turn makes libata EH ignore AC_ERR_DEV leading to incorrect
+ * error handling behaviors.
+ */
+ return;
+
if (!ata_id_has_sense_reporting(dev->id))
return;
--
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
