On Fri, Apr 10, 2015 at 07:55:25PM +0300, Sergei Shtylyov wrote: > >>- SIL24_FLAG_PCIX_IRQ_WOC = (1 << 24), /* IRQ loss errata on PCI-X */ > >>+ SIL24_FLAG_PCIX_IRQ_WOC = (1 << 25), /* IRQ loss errata on PCI-X */ > > This one also collides with ATA_FLAG_SAS_HOST. > > >And this will clash as soon as the next flag is added. Please don't > >abuse the common flag space for driver specific ones, and add a separate > >flags field for driver specific flags. > > Actually, bits 24-31 are reserved for the low-level driver usage (see the > comment below ATA_FLAG_*), so it's the new ATA_FLAG_LOWTAG and > ATA_FLAG_SAS_HOST that have violated the convention and should be moved > (there's plenty of lower bits due to the removal of some obsolete flags). Yeah, this something dumb I did way back. Can we please add a separate field for per-controller flags in port_info and all related structs so that we don't do this sharing? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
