Re: [PATCH] resolve collision of generic ATA_FLAG_LOWTAG and driver specific flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 04/09/2015 11:09 PM, Ronny Hegewald wrote:

The patch "libata: allow sata_sil24 to opt-out of tag ordered submission"
(72dd299d5039a336493993dcc63413cf31d0e662) introduces a regression with the
sata_sil24 driver.

The new flag ATA_FLAG_LOWTAG accidentially uses the same bit as

   Accidentally.

SIL24_FLAG_PCIX_IRQ_WOC in the driver. This activates code for Silicon Image
3132, which is only suppossed to run under 3124.

   Supposed.

ATA_FLAG_LOWTAG is only used in sata_sil24 and is planned to be removed soon,
so lets just use another bit for the flag in sata_sil24.

Actually, ATA_FLAG_LOWTAG has been removed in the 'for-next' branch, so this patch is no longer needed. Moreover, the newly assigned flag clashes with the new ATA_FLAG_SATA_PORT.

Signed-off-by: Ronny Hegewald <Ronny.Hegewald@xxxxxxxxx>

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux