Re: [PATCH v1 4/4] sata_dwc_460ex: fix most of the sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 07, 2015 at 03:24:22PM +0200, Andy Shevchenko wrote:
> There are a lot sparse warnings. Most of them related to __iomem keyword which
> sometimes absent when it's needed and vise versa.
> 
> The patch fixes most of the warnings.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Applied 1-4 to libata/for-3.19-fixes.  One nit below.

> @@ -1630,7 +1629,7 @@ static struct scsi_host_template sata_dwc_sht = {
>  	 * max of 1. This will get fixed in in a future release.
>  	 */
>  	.sg_tablesize		= LIBATA_MAX_PRD,
> -	.can_queue		= ATA_DEF_QUEUE,	/* ATA_MAX_QUEUE */
> +	/* .can_queue		= ATA_MAX_QUEUE, */

This part isn't explained by the patch description.  I added it while
applying but please make sure that the patch descriptions are
comprehensive.

Thanks!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux