On Tue, Oct 07, 2014 at 07:26:38AM -0400, George Spelvin wrote: > lib/glob.c provides a new glob_match() function, with arguments in > (pattern, string) order. It replaced a private function with arguments > in (string, pattern) order, but I didn't swap the call site... > > The result was the entire ATA blacklist was effectively disabled. > > The lesson for today is "I f***ed up *how* badly *how* many months ago?", > er, I mean "Nobody Tests RC Kernels On Legacy Hardware". > > This was not a subtle break, but it made it through an entire RC > cycle unreported, presumably because all the people doing testing > have full-featured hardware. > > (FWIW, the reason for the argument swap was because fnmatch() does it that > way, and for a while implementing a full fnmatch() was being considered.) > > Fixes: 428ac5fc056e0 (libata: Use glob_match from lib/glob.c) > Reported-by: Steven Honeyman <stevenhoneyman@xxxxxxxxx> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=71371#c21 > Signed-off-by: George Spelvin <linux@xxxxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> # 3.17 Oops, lol. Appiled to libata/for-3.17-fixes. Thanks! -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
