On 7 October 2014 12:26, George Spelvin <linux@xxxxxxxxxxx> wrote: > lib/glob.c provides a new glob_match() function, with arguments in > (pattern, string) order. It replaced a private function with arguments > in (string, pattern) order, but I didn't swap the call site... > > The result was the entire ATA blacklist was effectively disabled. Oops :) > The lesson for today is "I f***ed up *how* badly *how* many months ago?", > er, I mean "Nobody Tests RC Kernels On Legacy Hardware". > > This was not a subtle break, but it made it through an entire RC > cycle unreported, presumably because all the people doing testing > have full-featured hardware. Everyone makes mistakes - although I'd be very surprised there are no testers using the same SSD as mine. It's the most common mSATA drive around here in the UK at the moment (even if it has a slightly dodgy firmware!). > I'd like to wait to add a Tested-by, but it's also important enough > I want to publicly post a fix ASAP Pesky timezone differences! I was at work when you posted this patch, but just got home and recompiled. I can confirm this works: [ 3.845109] ata5.00: disabling queued TRIM support [ 3.845112] ata5.00: ATA-9: Crucial_CT240M500SSD3, MU05, max UDMA/133 ...although the patch didn't apply as a quick copy-paste job from Gmail ...but that's an unrelated matter :) Thanks again, Steven. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
