On Fri, Jul 11, 2014 at 10:51:05AM -0400, Tejun Heo wrote:
> On Fri, Jul 11, 2014 at 02:10:26PM +0800, Kevin Hao wrote:
> > static struct ata_queued_cmd *ata_qc_new(struct ata_port *ap)
> > {
> > struct ata_queued_cmd *qc = NULL;
> > - unsigned int i, tag;
> > + unsigned int i, tag, max_queue;
> > +
> > + max_queue = ap->scsi_host->can_queue;
> > + WARN_ON_ONCE(max_queue > ATA_MAX_QUEUE);
>
> Let's move the WARN_ON_ONCE() to ata_host_register(). Also, let's
> please update the function comment explaining why we're allocating
> tags the way we do.
OK, will do.
Thanks,
Kevin
Attachment:
pgpZhcrDtGSFr.pgp
Description: PGP signature
