On Fri, Jul 11, 2014 at 02:10:26PM +0800, Kevin Hao wrote:
> static struct ata_queued_cmd *ata_qc_new(struct ata_port *ap)
> {
> struct ata_queued_cmd *qc = NULL;
> - unsigned int i, tag;
> + unsigned int i, tag, max_queue;
> +
> + max_queue = ap->scsi_host->can_queue;
> + WARN_ON_ONCE(max_queue > ATA_MAX_QUEUE);
Let's move the WARN_ON_ONCE() to ata_host_register(). Also, let's
please update the function comment explaining why we're allocating
tags the way we do.
Other than that, it looks good to me.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
