Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sebastian,

On Tue, Jun 17, 2014 at 08:17:02PM +0200, Sebastian Hesselbarth wrote:
> On 06/16/2014 12:26 PM, Antoine Ténart wrote:
> > +
> > +#define PHY_BASE		0x200
> 
> Antoine,
> 
> I gave your Berlin AHCI patches a try on BG2. I finally got it working
> but BG2 has a different PHY_BASE and need some register fixups.
> 
> Please update this patch and the DT bindings to reflect the difference
> of BG2Q with respect to BG2 as below.
> 
> [...]
> > +
> > +static const struct of_device_id phy_berlin_sata_of_match[] = {
> > +	{ .compatible = "marvell,berlin-sata-phy" },
> 
> s/marvell,berlin-sata-phy/marvell,berlin2-sata-phy/
> 
> and add
> 
> marvell,berlin2q-sata-phy
> 
> That way it can be applied now without proper support for BG2
> and I can send patches later.

Sure. I'll just s/marvell,berlin-sata-phy/marvell,berlin2q-sata-phy/ so
we don't have a non working compatible.

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux