On Mon, Mar 31, 2014 at 11:19 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@xxxxxxxxxxx> wrote:
> Add missing cf_exit() and clk_put() calls to ata_host_activate()
> failure path.
>
> Cc: Viresh Kumar <viresh.linux@xxxxxxxxx>
> Cc: Shiraz Hashim <shiraz.hashim@xxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> ---
> drivers/ata/pata_arasan_cf.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> Index: b/drivers/ata/pata_arasan_cf.c
> ===================================================================
> --- a/drivers/ata/pata_arasan_cf.c 2014-03-31 16:57:47.443727785 +0200
> +++ b/drivers/ata/pata_arasan_cf.c 2014-03-31 17:09:48.171715498 +0200
> @@ -898,9 +898,15 @@ static int arasan_cf_probe(struct platfo
>
> cf_card_detect(acdev, 0);
>
> - return ata_host_activate(host, acdev->irq, irq_handler, 0,
> - &arasan_cf_sht);
> + ret = ata_host_activate(host, acdev->irq, irq_handler, 0,
> + &arasan_cf_sht);
> + if (ret)
> + goto exit_cf;
>
> + return 0;
Probably this would be better:
if (!ret)
return 0
and then no need of a goto..
> +
> +exit_cf:
> + cf_exit(acdev);
> free_clk:
> clk_put(acdev->clk);
> return ret;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
