On 03/14/2014 08:58 PM, Tejun Heo wrote: > On Fri, Mar 14, 2014 at 01:46:09PM +0800, Aaron Lu wrote: >> If ACPI handle for an ATA device is NULL, we shouldn't call >> ata_dev_get_GTF as that function will use handle to do some ACPI >> evaluation. > > This caused a crash, right? Can you please include what can trigger > such oops and how it looks like and reference to the original bug > report. In general, when you're cc'ing stable, please try to provide > as much information about the bug as possible so that downstreams have > easier time evaluating the importance and risk of the change. The > same goes for the previous patch. It shouldn't cause a crash, just some error messages from ACPICA I think. There isn't a bug for it right now, I have only some vague memory that I saw such error messages when dealing with some other bugs some time ago. So perhaps I shouldn't add the stable tag, sorry for that, this seems to belong to the 'this patch solves a potential problem' case... For the 1/3 patch, no crash either. It's just that if CONFIG_PM_RUNTIME is not set, ZPODD will not function so building it doesn't make sense. Thanks, Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
