On Sat, Mar 8, 2014 at 7:28 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
>
> Just a couple patches blacklisting more broken devices.
Pulled. However:
> /* devices that don't properly handle queued TRIM commands */
> { "Micron_M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM, },
> { "Crucial_CT???M500SSD1", NULL, ATA_HORKAGE_NO_NCQ_TRIM, },
> + { "Crucial_CT???M500SSD3", NULL, ATA_HORKAGE_NO_NCQ_TRIM, },
If we know M500SSD1 and M500SSD3 are both broken the same way, and the
Micron_M500* is too (which is, as far as I know, the same device), why
the heck do we make the test that specific?
Why not just use Crucial_CT???M500* or something? The likelihood of
some new version of the same broken device coming up is small, and if
it does, we don't even care. Why would we risk it?
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
