On Wed, Feb 19, 2014 at 01:01:47PM +0100, Hans de Goede wrote: > @@ -268,6 +281,9 @@ pdata_exit: > pdata->exit(dev); > disable_unprepare_clk: > ahci_disable_clks(hpriv); > +disable_regulator: > + if (hpriv->target_pwr) > + regulator_disable(hpriv->target_pwr); The same thing with clks, I'd much prefer to see ahci_platform doing devres wrapping so that its consumers wouldn't have to worry about tearing stuff down. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html