2014-02-19 21:38 GMT+09:00 Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>: > Hello. > > > On 19-0202014 9:07, Daeseok Youn wrote: > >> From 2a428e5e45bca3fc38fad17b9e2e14c5e6514ca0 Mon Sep 17 00:00:00 2001 >> From: Daeseok Youn <daeseok.youn@xxxxxxxxx> >> Date: Wed, 19 Feb 2014 10:56:37 +0900 >> Subject: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static > > > This header is not needed. Actually, this patch was made by "git format-patch" command and attached to mail client. > > >> sparse says: > > >> drivers/ata/libahci.c:1390:5: warning: >> symbol 'ahci_pmp_retry_softreset' was not declared. Should it be static? > > >> Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx> >> --- >> drivers/ata/libahci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > >> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c >> index 36605ab..f9600fe 100644 >> --- a/drivers/ata/libahci.c >> +++ b/drivers/ata/libahci.c >> @@ -1387,7 +1387,7 @@ static int ahci_bad_pmp_check_ready(struct ata_link >> *link) >> return ata_check_ready(status); >> } >> >> -int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class, >> +static int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int >> *class, >> unsigned long deadline) > > > Realign this continuation line too, for it to start under *struct* on > the first line. I will realign and send this patch again. > > WBR, Sergei > Thanks for your comment. Daeseok Youn. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html