On Sun, Jan 19, 2014 at 12:48:45AM +0100, Hans de Goede wrote: > For devices where ahci_platform_data provides suspend() there is an unbalance > in clk enable/disable calls. The suspend path does not disable the clk, but > the resume path enables it. This commit fixes it by always disabling the clk > in the suspend path independent of there being an ahci_platform_data suspend > method. > > On all drivers currently using a suspend method, the suspend method always > succeeds, so change its return type to void, to avoid having the introduce > somewhat complex error handling paths. > > The disabling of the clock on suspend is a functional change, to ensure this > is ok I've audited all drivers using ahci_platform_data: > > arch/arm/mach-davinci/devices-da8xx.c: Does not use a suspend method > arch/arm/mach-spear/spear1340.c: Does not use the clock framework > drivers/ata/ahci_imx.c: Does have suspend and resume pdata methods, these > disable / enable another clock, so likely it is ok to disable / enable the > clock at of-node index 0 as well, I've ordered a wandboard to be able to > test these changes. This isn't your fault but similarly to the previous patch, I'd much prefer if drivers which need custom ops just override the whole operation and are allowed to use the default platform from their custom implementations as they see fit. Allowing partial overrides seems like an efficient thing to do at the beginning but if you continue to stack them, you eventually end up with giant pile of methods where figuring out which code paths are actually executed takes quite a bit of effort. I'd really like to avoid that. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
