On Tue, Jan 14, 2014 at 10:14:04AM -0500, Jason Cooper wrote: > Simon, > > On Tue, Jan 14, 2014 at 03:50:04PM +0100, Simon Guinot wrote: > > Hello, > > > > This patch series fixes a SATA disk hotplug issue for the Armada 370/XP > > SoCs: once a disk is removed from a SATA port, then the re-plug events > > are not detected by the sata_mv driver. > > > > This should be applied to the -stable kernels 3.10 and onwards. > > Please add a 'Fixes: <commit-hash> (oneline)' tag below the Cc: stable > tags. It looks like the sata_mv binding and the Armada 370 DT booting > were both introduced in v3.6, so I would probably use: > > Fixes: 9ae6f740b49f (arm: mach-mvebu: add support for Armada 370 and Armada XP with DT) Hi Jason, I am not comfortable with this "Fixes: commit_id" notation. It states that the patch fixes a regression introduced by a given commit. This hardly makes sense to me because obviously the hotplug issue has not been introduced by: "arm: mach-mvebu: add support for Armada 370 and Armada XP with DT". I know that the purpose is purely administrative, but it is kind of weird... > > Is there a specific reason you say v3.10? I could have said nothing as well. As stable kernel older than 3.10 are no longer maintained, I think we don't need to point out a specific commit as a -stable target. Simply Cc'ing -stable without any extra informations should be good enough. > > Once you've incorporated Gregory's comments, > > Acked-by: Jason Cooper <jason@xxxxxxxxxxxxxx> OK. Thanks, Simon > > > Lior Amsalem (1): > > ata: sata_mv: fix disk hotplug for Armada 370/XP SoCs > > > > Simon Guinot (2): > > ata: sata_mv: introduce compatible string "marvell,armada-370-xp-sata" > > ARM: mvebu: update the SATA compatible string for Armada 370/XP > > > > Documentation/devicetree/bindings/ata/marvell.txt | 2 +- > > arch/arm/boot/dts/armada-370-xp.dtsi | 2 +- > > drivers/ata/sata_mv.c | 25 +++++++++++++++++++++++ > > 3 files changed, 27 insertions(+), 2 deletions(-) > > Tejun, > > I see no point to breaking up this series only to have both pieces end > up in stable. Are you ok with taking the whole thing? > > thx, > > Jason.
Attachment:
signature.asc
Description: Digital signature
