Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Mon, Jan 13, 2014 at 11:55:44AM -0800, Todd E Brandt wrote:
> I see your point, why have two paths if one will do. The only thing that
> worries me is that the PM resume from hibernate function doesn't have
> an error handler. What happens when it tries to read the image from swap
> and the disk is still spinning up? The scsi layer has an error handler so

The request gets blocked on EH.

> it just keeps retrying every few seconds, but the PM core reads directly
> from the swap disk's block device.

Why would that matter?  Resume is handled by EH.  While EH is in
progress, all commands are blocked.  Am I missing something?

> > So, can't just everything become async?  Are there cases where we
> > *need* synchronous PM behaviors?
> 
> I think suspend still needs to be synchronous, because the PM core needs
> to be sure that the disks are actually spun down before it can attempt
> to shut the system down. I'm adding Raphael to the thread. Raphael, is 
> this correct?

Yeah, we definitely should wait for suspend to complete before
entering suspend state.  I was referring to the resume path.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux