Hello, On Sat, Jan 04, 2014 at 10:14:35AM +0100, Hans de Goede wrote: > @@ -323,6 +323,8 @@ struct ahci_host_priv { > u32 em_msg_type; /* EM message type */ > struct clk *clk; /* Only for platforms supporting clk */ > void *plat_data; /* Other platform data */ > + /* Optional pre ahci_start_engine hook */ > + void (*pre_start_engine)(struct ata_port *ap); I'd much prefer if the callback overrides start_engine itself rather than adding a hook inside start_engine. This is a bit too specific. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html