On Thu, 9 Jan 2014, Phillip Susi wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 1/9/2014 10:40 AM, Alan Stern wrote: > > We should change the code in the block layer. blk_pm_peek_request > > should allow requests with REQ_PM set to go through, no matter > > what the rpm_status is. Then the disk driver could query the disk > > (to see whether it is spinning) while the disk remains in runtime > > suspend. > > No, because if the disk is RPM_SUSPENDED, the port may be > RPM_SUSPENDED, which likely means that you CAN'T send down requests to > the device. That's true, but it isn't a problem. We know that requests with REQ_PM are sent only at certain, controlled times. In particular, the only time such a request would be sent while the disk is RPM_SUSPENDED is during a system resume. > We need to put the device into one of the transitioning states to > block other IO, without allowing the port to suspend. No, we only need to make sure that the port doesn't go into runtime suspend while we carry out the "is the disk spinning" test. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
