On Mon, Dec 23, 2013 at 01:07:35PM +0100, Simon Guinot wrote: > From: Lior Amsalem <alior@xxxxxxxxxxx> > > From: Lior Amsalem <alior@xxxxxxxxxxx> > > This patch fixes a SATA hotplug issue on the Armada 370 and Armada XP > SoCs. Without it, if a disk is unplugged from a SATA port, then further > hotplug notification are now longer received on this port. > > This should be applied to every -stable kernel supporting Armada SoCs. Could we get a little more specific here? Please determine which commit introduced the regression and note it with 'Fixes: <commitish> "oneline"' It's really needed here since the sata_mv driver predates the Armada SoCs introduction. Is it possible Kirkwood et al also experience this problem? thx, Jason. > > Signed-off-by: Lior Amsalem <alior@xxxxxxxxxxx> > Signed-off-by: Nadav Haklai <nadavh@xxxxxxxxxxx> > Signed-off-by: Simon Guinot <simon.guinot@xxxxxxxxxxxx> > Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> > Cc: Jason Cooper <jason@xxxxxxxxxxxxxx> > Cc: Andrew Lunn <andrew@xxxxxxx> > Cc: Gregory Clement <gregory.clement@xxxxxxxxxxxxxxxxxx> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > --- > drivers/ata/sata_mv.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c > index 56be318..89ca472 100644 > --- a/drivers/ata/sata_mv.c > +++ b/drivers/ata/sata_mv.c > @@ -304,6 +304,7 @@ enum { > MV5_LTMODE = 0x30, > MV5_PHY_CTL = 0x0C, > SATA_IFCFG = 0x050, > + LP_PHY_CTL = 0x058, > > MV_M2_PREAMP_MASK = 0x7e0, > > @@ -1358,6 +1359,7 @@ static int mv_scr_write(struct ata_link *link, unsigned int sc_reg_in, u32 val) > > if (ofs != 0xffffffffU) { > void __iomem *addr = mv_ap_base(link->ap) + ofs; > + void __iomem *lp_phy_addr = mv_ap_base(link->ap) + LP_PHY_CTL; > if (sc_reg_in == SCR_CONTROL) { > /* > * Workaround for 88SX60x1 FEr SATA#26: > @@ -1374,6 +1376,14 @@ static int mv_scr_write(struct ata_link *link, unsigned int sc_reg_in, u32 val) > */ > if ((val & 0xf) == 1 || (readl(addr) & 0xf) == 1) > val |= 0xf000; > + > + /* > + * Setting PHY speed according to SControl speed > + */ > + if ((val & 0xf0) == 0x10) > + writelfl(0x7, lp_phy_addr); > + else > + writelfl(0x227, lp_phy_addr); > } > writelfl(val, addr); > return 0; > -- > 1.8.5.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html