On Tue, Dec 17, 2013 at 12:19:21PM +0100, Borislav Petkov wrote: > On Tue, Dec 17, 2013 at 04:38:16PM +0530, Rashika Kheria wrote: > > Include appropriate header file ide-cd.h in ide-cd_verbose.c because > > function ide_cd_log_error() has its prototype declaration in ide-cd.h. > > Also, include linux/ide.h because it contains certain declarations > > necessary for including ide-cd.h. > > > > This eliminates the following warnings in ide-cd_verbose.c: > > drivers/ide/ide-cd_verbose.c:251:6: warning: no previous prototype for ‘ide_cd_log_error’ [-Wmissing-prototypes] > > drivers/ide/ is open only to fixes for serious, real bugs - nothing > else. I wouldn't waste my time with it if I were you. A quick check of "git log drivers/ide/" turns up a pile of fixes and cleanups; for instance: c2f7d1e ide: pmac: remove unnecessary pci_set_drvdata() a6fd6063 ide: cs5536: use module_pci_driver() 58e48be ide: pmac: Remove casting the return value which is a void pointer 64110c1 ide: sgiioc4: Staticize ioc4_ide_attach_one() 70ddce8 ide: palm_bk3710: add missing __iomem annotation The two proposed patches here are extremely low risk, don't actually change the compiled code in any way like some of those did, and fix real compiler warnings. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
