On Fri, Nov 22, 2013 at 12:26:45PM -0700, Troy Kisky wrote: > On 11/22/2013 4:04 AM, Marek Vasut wrote: > >We must clear this IMX6Q_GPR13_SATA_MPLL_CLK_EN bit on i.MX6Q, otherwise > >Linux will fail to find the attached drive on some boards. > > > >This entire fix was: > >Reported-by: Eric Nelson <eric.nelson@xxxxxxxxxxxxxxxxxxx> > > > >Signed-off-by: Marek Vasut <marex@xxxxxxx> > >Cc: Shawn Guo <shawn.guo@xxxxxxxxxx> > >Cc: Richard Zhu <r65037@xxxxxxxxxxxxx> > >Cc: Tejun Heo <tj@xxxxxxxxxx> > >Cc: Linux-IDE <linux-ide@xxxxxxxxxxxxxxx> > >--- > > drivers/ata/ahci_imx.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > >V2: Update the value in the comment from 0x7ffffffd to 0x7ffffffe > > > >diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c > >index ae2d73f..14227d1 100644 > >--- a/drivers/ata/ahci_imx.c > >+++ b/drivers/ata/ahci_imx.c > >@@ -113,7 +113,7 @@ static int imx6q_sata_init(struct device *dev, void __iomem *mmio) > > /* > > * set PHY Paremeters, two steps to configure the GPR13, > > * one write for rest of parameters, mask of first write > >- * is 0x07fffffd, and the other one write for setting > >+ * is 0x07fffffe, and the other one write for setting > > 0x07ffffff, d+2 = f, > bit 1 is IMX6Q_GPR13_SATA_MPLL_CLK_EN, which you just added > bit 0 is IMX6Q_GPR13_SATA_TX_EDGE_RATE, which is also in your expression Ah, sorry. The mistake comes from my wrong bit math. Shawn > > > * the mpll_clk_en. > > */ > > regmap_update_bits(imxpriv->gpr, 0x34, IMX6Q_GPR13_SATA_RX_EQ_VAL_MASK > >@@ -125,6 +125,7 @@ static int imx6q_sata_init(struct device *dev, void __iomem *mmio) > > | IMX6Q_GPR13_SATA_TX_BOOST_MASK > > | IMX6Q_GPR13_SATA_TX_LVL_MASK > > | IMX6Q_GPR13_SATA_TX_EDGE_RATE > >+ | IMX6Q_GPR13_SATA_MPLL_CLK_EN > > , IMX6Q_GPR13_SATA_RX_EQ_VAL_3_0_DB > > | IMX6Q_GPR13_SATA_RX_LOS_LVL_SATA2M > > | IMX6Q_GPR13_SATA_RX_DPLL_MODE_2P_4F > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
