Hi, >> +- CTLE0 : PHY override parameters for channel 0 register REG1 >> + field CTLE_EQ. First value for Gen1, second value >> + for Gen2, and third value for Gen3. Default is 0x2. >> +- CTLE1 : PHY override parameters for channel 1 register REG1 >> + field CTLE_EQ. First value for Gen1, second value >> + for Gen2, and third value for Gen3. Default is 0x2. >> +- PQ0 : PHY override parameters for channel 0 register REG125 >> + field PQ_REG. First value for Gen1, second value >> + for Gen2, and third value for Gen3. Default is 0xA. >> +- PQ1 : PHY override parameters for channel 1 register REG125 >> + field PQ_REG. First value for Gen1, second value >> + for Gen2, and third value for Gen3. Default is 0xA. > > As mentioned before, I don't think putting register-level information into the binding > is the right approach here. > [Loc Ho] I don't want to change the driver for every possible customer or APM boards out there. In general, if the board designer follows the board design guideline, this isn't necessary. Unfortunately, I can not control what customer do. If these setting is NOT driven by DTS, then I or others may have to change the driver every time there is an new board. Another option is pass them as module parameters. -Loc -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html