Re: [PATCH V4] sata_rcar: Add R-Car Gen2 SATA PHY support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 31, 2013 at 02:35:23PM +0400, Valentine wrote:
> On 10/31/2013 10:01 AM, Simon Horman wrote:
> >On Wed, Oct 30, 2013 at 09:14:21PM +0400, Valentine Barshak wrote:
> >>R-Car Gen2 SoCs have a different PHY which is not compatible
> >>with the older R-Car H1 (R8A7779) version.
> >>This adds OF/platform device id tables and PHY initialization
> >>callbacks for the following Gen2 SoCs:
> >>   * R-Car H2: R8A7790;
> >>   * R-Car M2: R8A7791.
> >>
> >>PHY initialization method is chosen based on the device id.
> >>Default PHY settings are applied for Gen2 SoCs, which should
> >>suit the Gen2 boards available.
> >>
> >>While at it, this also adds "sata-r8a7779" compatibility string
> >>for R-Car H1 SATA, while keeping the old one for compatibility.
> >>
> >>Signed-off-by: Valentine Barshak <valentine.barshak@xxxxxxxxxxxxxxxxxx>
> >
> >I know we are going around and around in circles regarding the bindings.
> >But I think you need to submit that patch which documents the bindings
> >that exist after this patch in order for the bindings, as they are
> >used here, to be reviewed by the device tree people.
> 
> OK, I'll resend.
> 
> >
> >Also, I think I found a typo which I have noted below.
> 
> There's no typo. I'm using "sata_rcar" device name for compatibility with the current r8a7779 code
> that uses the driver and registers "sata_rcar" device.

Thanks, sorry for the noise.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux