Hello. On 04-10-2013 7:19, Jingoo Han wrote:
Use the printk(KERN_INFO,...) call to to dev_info() instead, to tie into the dynamic debugging infrastructure.
I can't even parse this sentence, not to mention dev_info() has no relation to dynamic debugging.
Also change "raw" printk() call to dev_info() to provide a better error message to userspace so it can properly identify the device and not just have to guess.
I'm only seeing the second change in your patch.
Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
[...]
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 9d715ae..8e28f92 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1343,7 +1343,7 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss) host->flags |= ATA_HOST_PARALLEL_SCAN; else - printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n"); + dev_info(&pdev->dev, "SSS flag set, parallel bus scan disabled\n");
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
