Re: [PATCH v2] ata_piix: minor typo and a printk fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2013-09-30 21:36 keltezéssel, Tejun Heo írta:
> Hello,
> 
> Tried to apply it but patch seems whitespace damaged and doesn't
> apply.  Please resend.  Also, one comment.
> 
> On Fri, Sep 27, 2013 at 04:15:36PM +0200, Levente Kurusa wrote:
>> -	ICH5_PMR		= 0x90, /* port mapping register */
>> +	ICH5_PMR		= 0x90, /* address map register */
> 
> I don't know whether the name has changed but PMR at least did stand
> for Port Mapping Register.  I don't see much point in updating the
> comment here.
> 
> Thanks.
> 

According to the specifications of ICH5, it is called
Address Map Register. I didn't want to change the variable's name,
because I think it would cause some headaches for those wanting to find
information on google.
http://www.intel.com/content/dam/doc/datasheet/82801eb-82801er-io-controller-hub-datasheet.pdf
See Chapter 11.1.32

The patch gets whitespace damaged due to Thunderbird, I will experiment
before resending it again.

-- 
Regards,
Levente Kurusa
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux