Hi Yuvaraj, On 1 October 2013 12:03, Yuvaraj Kumar C D <yuvaraj.cd@xxxxxxxxx> wrote: > This patch adds dt entry for ahci sata controller and its > corresponding phy controller.phy node has been added w.r.t > new generic phy framework. [snip] > + > + sata-phy { Shouldn't this be sata-phy@38? > + compatible = "sata-phy-i2c"; > + reg = <0x38>; > + }; [snip] > - sata-phy@12170000 { > - compatible = "samsung,exynos5-sata-phy"; > + sata_phy:sata-phy@12170000 { nit: A space after sata_phy: would be good. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html