Re: [PATCH] ata_piix: minor typo fixes and threading fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2013/9/26 Tejun Heo <tj@xxxxxxxxxx>:
> (cc'ing Kay)
>
> On Wed, Sep 25, 2013 at 04:40:30PM +0200, Levente Kurusa wrote:
>> I am getting the following output:
>> [    2.236379] ata_piix 0000:00:1f.2: MAP [
>> [    2.236492]  P0 P2 -- -- ]
>> Instead of the expected:
>> [    2.236379] ata_piix 0000:00:1f.2: MAP [ P0 P2 -- -- ]
>>
>> This might be a minor problem, but I think it is better the second way.
>> Of course, now that I better understand the code, I see that my fix to this,
>> is not the best. I will make a new patch, if you think this should be fixed.
>
> Hmmm... so, you're saying pr_cont() is misbehaving after dev_info()?
> If so, we don't want to paper over that from a low level driver like
> ata_piix.  Let's find out what's going on with pr_cont().
>
Yes, however I am not familiar with printk() and the likes (like _dev_info()),
but it looks like either _dev_info() is putting a trailing '\n' or
only KERN_CONT
lines can be continued, which is probably not the way it is, because I think
that sort of defeats the purpose.

Regards,
Levente Kurusa
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux