Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 09/23/2013 01:48 AM, Tejun Heo wrote:

@@ -37,6 +37,7 @@

  #include <linux/clk.h>
  #include <linux/libata.h>
+#include <linux/phy/phy.h>

struct phy;

should suffice.

Unless it's actually likely to cause inclusion loop, I think it's
better to include the header than adding explicit declarations.

Apparently, tastes differ here. E.g. Greg KH would have also told Roger to use forward declaration in such case. :-)

Thanks.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux