> -----Original Message----- > From: Joe Perches [mailto:joe@xxxxxxxxxxx] > Sent: Wednesday, September 18, 2013 12:24 AM > To: Liu, Chuansheng > Cc: tj@xxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] ahci: Changing two module params with static and > __read_mostly > > On Wed, 2013-09-18 at 00:48 +0800, Chuansheng Liu wrote: > > Here module parameters ahci_em_messages and devslp_idle_timeout can > > be set as static and __read_mostly. > > > > Signed-off-by: Liu, Chuansheng <chuansheng.liu@xxxxxxxxx> > > --- > > drivers/ata/libahci.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c > [] > > @@ -189,14 +189,15 @@ struct ata_port_operations > ahci_pmp_retry_srst_ops = { > > }; > > EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops); > > > > -int ahci_em_messages = 1; > > +static int ahci_em_messages __read_mostly = 1; > > This one could also be converted to > static bool ahci_em_messages __read_mostly = true; > Thanks, will update one new patch. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
