All the same checks are preserved, including the manage_start_stop check: + if (!sdkp->device->manage_start_stop) + goto error; That function is just a simplified version of sd_start_stop_device but with only the start functionality used. -----Original Message----- From: Oliver Neukum [mailto:oneukum@xxxxxxx] Sent: Saturday, August 24, 2013 1:21 AM To: Brandt, Todd E Cc: linux-ide@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; tj@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH v3 2/2] Hard disk S3 resume time optimization On Fri, 2013-08-23 at 14:43 -0700, Brandt, Todd E wrote: > This is v3 of the non-blocking S3 resume patch. It's been broken into > two pieces, this part is for the scsi subsystem. I've addressed Alan > Stern's comments in particular by reformatting the call to conform > to the proper style guidelines. Hi, you are changing the generic resume for all sd disks. In particular, you are dropping the check of sdkp->device->manage_start_stop What happens if you use this patch on a real SCSI disk? Regards Oliver ��.n��������+%������w��{.n�����{��'^�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
