Re: [PATCH v4 1/3] libata: Populate host-to-device FIS "auxiliary" field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23-08-2013 13:40, Marc C wrote:

From: Marc Carino <marc.ceeeee@xxxxxxxxx>

SATA 3.1 added an "auxiliary" field to the host-to-device FIS.
Populate the host-to-device FIS with the new field via the
taskfile struct.

Signed-off-by: Marc Carino <marc.ceeeee@xxxxxxxxx>
---
  drivers/ata/ahci.c        |  8 ++++++++
  drivers/ata/libata-core.c | 10 ++++++----
  include/linux/libata.h    |  5 +++++
  3 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 5064f3e..8d41c57 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1288,6 +1288,14 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
  		 */
  		if (!(hpriv->flags & AHCI_HFLAG_NO_FPDMA_AA))
  			pi.flags |= ATA_FLAG_FPDMA_AA;
+
+		/*
+		 * All AHCI controllers should be forward-compatible
+		 * with the new auxiliary field. This code should be
+		 * conditionalized if any buggy AHCI controllers are
+		 * encountered.
+		 */
+		pi.flags |= ATA_FLAG_FPDMA_AUX;
[...]
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 283d66b..6539c50 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -223,6 +223,7 @@ enum {
  	ATA_FLAG_ACPI_SATA	= (1 << 17), /* need native SATA ACPI layout */
  	ATA_FLAG_AN		= (1 << 18), /* controller supports AN */
  	ATA_FLAG_PMP		= (1 << 19), /* controller supports PMP */
+	ATA_FLAG_FPDMA_AUX	= (1 << 20), /* controller supports H2DFIS aux field */

   I think adding this flag is a matter of a separate patch.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux