Re: [PATCH 1/2] libata: Add support for SEND/RECEIVE FPDMA QUEUED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,
>    Real name is required in signoff.
Got it. I will update it in the resubmission.

>> diff --git a/include/linux/ata.h b/include/linux/ata.h
>> index ee0bd95..dd26211 100644
>> --- a/include/linux/ata.h
>> +++ b/include/linux/ata.h
> [...]
>> @@ -509,6 +525,8 @@ struct ata_taskfile {
>>       u8            device;
>>
>>       u8            command;    /* IO operation */
>> +
>> +    u32            auxiliary;
>
>    The 'struct ata_taskfile' has been moved to libata.h for 3.12, so
> you are basing your work off of the wrong branch.
My bad! I'll rebase my tree to 3.12.

>    And what does this new field have to do with the classical ATA
> taskfile registers? Can't we place it into 'struct ata_queued_cmd'? 
Actually, nothing, since it's impossible to transport the new field via
a legacy TF.  'struct ata_queued_cmd' is a more appropriate place to put
it. Thank you for pointing that out.

Regards,
Marc
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux