Hello, Gwendal. On Fri, Jun 14, 2013 at 01:48:33PM -0700, Gwendal Grignou wrote: > Remove duplicate Medium Error Entry. > Remove the ABRT entry: it is too broad: when only ABRT is set > we should look at status for more information. > Only if status does not provide information we set ABORTED_COMMAND > sense key. > > Tested: When a disk fails, it sets > Status = 0x71 [DRDY DF ERR] , Error = 0x4 [ABRT] > Ensure the sense key is HARDWARE_ERROR. > When there is a simple command syntax error: > Status = 0x51 [DRDY ERR] , Error = 0x4 [ABRT] > Ensure the sense key is ABORTED_COMMAND. But this would trigger "no sense translation" warning. The translation in that function is pretty simplistic anyway. Can you please update the patch so that there's a comment noting why we aren't mapping 0x04 and drop the warning? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html