On Monday, June 03, 2013 1:34 PM, Tejun Heo wrote:
> On Mon, Jun 03, 2013 at 01:22:41PM +0900, Jingoo Han wrote:
> > Use the wrapper functions for getting the driver data using pci_dev
> > instead of using dev_get,set_drvdata() with &pdev->dev, so we can
I will fix this typo:
dev_get,set_drvdata() -> dev_get_drvdata()
> > directly pass a struct pci_dev.
> >
> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> > ---
> > Changes since v1:
> > - Fix the commit message from pci_{get,set}_drvdata() to pci_get_drvdata()
>
> Ummm... wouldn't using pci_set_drvdata() make things more consistent?
Usually, both pci_set_drvdata() and pci_get_drvdata() are used.
But, I cannot find where pci_set_drvdata() can be used in ./drivers/ata/*.
> Also, what about the other comment that I made? Is this purely
> cosmetic or is there some other change which is gonna depend on it?
This is purely _cosmetic_. There are no other changes.
Best regards,
Jingoo Han
>
> Thanks.
>
> --
> tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
