Re: [PATCH] ipr: qc_fill_rtf() method should not store alternate status register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/21/2013 02:24 PM, Sergei Shtylyov wrote:
> The 'ctl' field of  the 'struct ata_taskfile' is not really dual purpose, i.e.
> it is not intended  for storing the alternate status register (which is mapped
> at the same address in the legacy IDE controllers) in the qc_fill_rtf() method.
> No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status
> register's value in the 'ctl' field of 'qc->result_tf', hence this driver should
> not do this as well...
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

Acked-by: Brian King <brking@xxxxxxxxxxxxxxxxxx>

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux