Yours work. On Fri, Mar 29, 2013 at 9:10 AM, Krzysztof Mazur <krzysiek@xxxxxxxxxxxx> wrote: > On Fri, Mar 29, 2013 at 08:26:41AM -0700, Gwendal Grignou wrote: >> commit 84a9a8cd9d0aa93c17e5815ab8a9cc4c0a765c63 changed the sense key >> used for returning task registers, but HDIO_DRIVE_CMD ioctl was >> not changed accordingly. >> >> Tested: check that SMART ENABLE sent using HDIO_DRIVE_CMD returns 0 >> instead of EIO. >> >> Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxx> >> --- >> drivers/ata/libata-scsi.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c >> index 318b413..e05bf4c 100644 >> --- a/drivers/ata/libata-scsi.c >> +++ b/drivers/ata/libata-scsi.c >> @@ -532,8 +532,8 @@ int ata_cmd_ioctl(struct scsi_device *scsidev, void __user *arg) >> struct scsi_sense_hdr sshdr; >> scsi_normalize_sense(sensebuf, SCSI_SENSE_BUFFERSIZE, >> &sshdr); >> - if (sshdr.sense_key == 0 && >> - sshdr.asc == 0 && sshdr.ascq == 0) >> + if (sshdr.sense_key == RECOVERED_ERROR && >> + sshdr.asc == 0 && sshdr.ascq == 0x1D) >> cmd_result &= ~SAM_STAT_CHECK_CONDITION; >> } >> >> -- >> 1.8.1.3 > > I did not test your patch, but I think that you missed the second > test in ata_task_ioctl() and the kernel will still return -EIO > in case of HDIO_DRIVE_TASK (0x31e) ioctl. > See http://marc.info/?l=linux-kernel&m=136438868606981&w=2. > The version I've sent fixes the problem for me. > > Krzysiek -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
