On 12/04/2012 01:10 AM, Brian Norris wrote:
>I can seem to find it. Without knowing what that does, I would be inclined
>to NACK the whole thing.
A NACK is probably the right thing. I was mostly converting a few
other drivers which used some simple, common patterns to use my new
common code, but this driver was missing it altogether. It looks like
there may be bigger issues, though, as you point out.
>How did you test the patch?
I didn't; I don't have a cavium-octeon system.
>This patch is likely to be incomplete as the driver is also missing the
>module_exit() things.
>
>It might be simpler to just make the driver "bool" instead of "tristate" in
>the Kconfig.
As noted earlier, I don't have much interest in this driver. I agree
that there are some other issues with the driver; I think it leaks
memory if it is ever allowed to unload, for one. Feel free to submit
an alternative patch to prevent this driver from being built as a
module.
reverted
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
